Michal Skrivanek has posted comments on this change. Change subject: core: add support for tunnel migration ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java Line 252: public static final String offline = "offline"; Line 253: public static final String online = "online"; Line 254: public static final String domains = "storageDomains"; Line 255: public static final String hooks = "hooks"; Line 256: public static final String tunneled = "tunneled"; the other migration related constants are lowercase, IMO better keep the current case and leve this for a separate code change Line 257: Line 258: // storage domains Line 259: public static final String code = "code"; Line 260: public static final String lastCheck = "lastCheck"; -- To view, visit http://gerrit.ovirt.org/11062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa684df7376f8470fe729d590ce0e63d39c4d1e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
