Omer Frenkel has posted comments on this change. Change subject: core: add support for tunnel migration ......................................................................
Patch Set 1: (3 inline comments) fixed according to the comments, thanks .................................................... File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql Line 137: select fn_db_add_config_value('HotPlugUnsupportedOsList','','general'); Line 138: select fn_db_add_config_value('InitStorageSparseSizeInGB','1','general'); Line 139: select fn_db_add_config_value('TunnelMigrationEnabled','false','3.0'); Line 140: select fn_db_add_config_value('TunnelMigrationEnabled','false','3.1'); Line 141: select fn_db_add_config_value('TunnelMigrationEnabled','true','3.2'); done, i will add 3.3 cluster support to the engine in a different patch Line 142: --Handling Install virtualization software on Add Host Line 143: Line 144: select fn_db_add_config_value('InstallVds','true','general'); Line 145: select fn_db_add_config_value('IoOpTimeoutSec','10','general'); .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java Line 62: Line 63: /** Line 64: * @param version Line 65: * Compatibility version to check for. Line 66: * @return <code>true</code> if anti MAC spoofing is supported for the version, <code>false</code> if it's not. Done Line 67: */ Line 68: public static boolean tunnelMigration(Version version) { Line 69: return supportedInConfig(ConfigValues.TunnelMigrationEnabled, version); Line 70: } .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java Line 252: public static final String offline = "offline"; Line 253: public static final String online = "online"; Line 254: public static final String domains = "storageDomains"; Line 255: public static final String hooks = "hooks"; Line 256: public static final String tunnlled = "tunnlled"; Done Line 257: Line 258: // storage domains Line 259: public static final String code = "code"; Line 260: public static final String lastCheck = "lastCheck"; -- To view, visit http://gerrit.ovirt.org/11062 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fa684df7376f8470fe729d590ce0e63d39c4d1e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches