Einav Cohen has posted comments on this change.
Change subject: restapi: default version to 'general'
......................................................................
Patch Set 3:
Michael: Note that we have the following warning message written in the engine
log in case "null" version was sent:
2013-01-16 00:18:55,834 WARN
[org.ovirt.engine.core.bll.GetConfigurationValueQuery] (http-/0.0.0.0:8443-5)
calling GetConfigurationValueQuery (ApplicationMode) with null version, using
default general for version
this warning is being written to the log because the user is expected to
explicitly provide the version when asking for a configuration value.
setting the version value in the Parameters class (as you suggested) will not
do any good - it will be just "cover-up" the cases in which the user did not
explicitly provide version ("cover-up" == no warning message will be written to
the engine.log). We might as well just remove the warning-message-writing
altogether - it will be exactly the same.
--
To view, visit http://gerrit.ovirt.org/11173
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I946c9925f3e0b94a9dad86f0958c2f9e1d0ab5c8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
