Michael Pasternak has posted comments on this change.
Change subject: restapi: default version to 'general'
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
Line 234: new GetConfigurationValueParameters(config,
asString(version)),
Line 235: config.toString());
Line 236: }
Line 237:
Line 238: protected <T> T getConfigurationValueDefault(Class<T> clz,
ConfigurationValues config) {
no need for this change, please see my comment in LoginValidator on this.
Line 239: return getEntity(clz,
Line 240: VdcQueryType.GetConfigurationValue,
Line 241: new GetConfigurationValueParameters(config,
ConfigCommon.defaultConfigurationVersion),
Line 242: config.toString());
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
Line 114: }
Line 115:
Line 116: private ApplicationMode getApplicationMode() {
Line 117: VdcQueryReturnValue result =
backend.RunPublicQuery(VdcQueryType.GetConfigurationValue,
Line 118: new
GetConfigurationValueParameters(ConfigurationValues.ApplicationMode,
ConfigCommon.defaultConfigurationVersion));
why not setting defaultConfigurationVersion in
GetConfigurationValueParameters.privateVersion? this way you don't have to
force everyone setting it explicitly every time, i.e the one that wants using
'general' version, can simply use constructor without version.
Line 119: ApplicationMode appMode = null;
Line 120: if (result.getSucceeded())
Line 121: {
Line 122: appMode = ApplicationMode.from((Integer)
result.getReturnValue());
--
To view, visit http://gerrit.ovirt.org/11173
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I946c9925f3e0b94a9dad86f0958c2f9e1d0ab5c8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
