Gilad Chaplik has posted comments on this change.
Change subject: engine: Corrections to Event.equal to avoid confusions and
unexpected behaviors.
......................................................................
Patch Set 2: (4 inline comments)
....................................................
File
backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/Event.java
Line 99: }
Line 100: }
Line 101:
Line 102: @Override
Line 103: public int hashCode() {
where do we use that?
Line 104: final int prime = 31;
Line 105: int result = 1;
Line 106: result = prime * result + ((privateName == null) ? 0 :
privateName.hashCode());
Line 107: result = prime * result + ((privateOwnerType == null) ? 0 :
privateOwnerType.hashCode());
Line 107: result = prime * result + ((privateOwnerType == null) ? 0 :
privateOwnerType.hashCode());
Line 108: return result;
Line 109: }
Line 110: @Override
Line 111: public boolean equals(Object obj) {
where do we use that?
for both, unless used, I suggest to remove both
Line 112: if (this == obj)
Line 113: return true;
Line 114: if (obj == null)
Line 115: return false;
Line 131: public boolean matchesDefinition(EventDefinition other) {
Line 132: if(other == null){
Line 133: return false;
Line 134: }
Line 135: return StringHelper.stringsEqual(getName(), other.getName())
use String.equals()
Line 136: && getOwnerType() == other.getOwnerType();
Line 137: }
Line 138:
Line 139: public java.util.List<IEventListener> getListeners() {
Line 132: if(other == null){
Line 133: return false;
Line 134: }
Line 135: return StringHelper.stringsEqual(getName(), other.getName())
Line 136: && getOwnerType() == other.getOwnerType();
use eqauls
Line 137: }
Line 138:
Line 139: public java.util.List<IEventListener> getListeners() {
Line 140: return listeners;
--
To view, visit http://gerrit.ovirt.org/10955
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idca42d6a61454162db412429e55898f15152c12d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
