Allon Mureinik has posted comments on this change. Change subject: engine: Corrections to Event.equal to avoid confusions and unexpected behaviors. ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (2 inline comments) +2 on backend part, but please fix the minor issues in the commit message when you rebase. Daniel/Gilad, please review the frontend part. .................................................... Commit Message Line 9: - Changed the covariant version of the Event.equals(Event other) to Line 10: override standard java Object.equals(Object other), the equality is a natural identity Line 11: and is based on the privateName & privateOwnerType properties. Line 12: Line 13: - Generated a hashmap which is compatible with the equals implementation. s/hashCode()/hashmap Line 14: Line 15: - Renamed Event.equals(EventDefinition ed) to Event.matchesDefinition(EventDefinition ed) as the name Line 16: of the method overloads java standard Object.equals(Object other) method which is risky and may cause Line 17: unexpected behaviors. Line 13: - Generated a hashmap which is compatible with the equals implementation. Line 14: Line 15: - Renamed Event.equals(EventDefinition ed) to Event.matchesDefinition(EventDefinition ed) as the name Line 16: of the method overloads java standard Object.equals(Object other) method which is risky and may cause Line 17: unexpected behaviors. some of the lines here (15, 16) are a bit long. Please keep to 70 characters Line 18: Line 19: Change-Id: Idca42d6a61454162db412429e55898f15152c12d -- To view, visit http://gerrit.ovirt.org/10955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idca42d6a61454162db412429e55898f15152c12d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Asaf Shakarchi <a...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
