Oved Ourfali has posted comments on this change.
Change subject: Introducing ShellBox UI plugin
......................................................................
Patch Set 1: (1 inline comment)
Maybe we can add it to guests as well, assuming for now that the name of the VM
is the FQDN.
(Currently that is the assumption you take on hosts as well... need to check if
the host address is exposed as well or not).
....................................................
File shellbox-plugin/shellbox-files/start.html
Line 34: api.ready();
Line 35:
Line 36: // Get 'Shell Box' URL using specified host address
Line 37: var getShellBoxUrl = function(arguments) {
Line 38: var hostAddress = arguments[0].name;
If the host address is also exposed then it is better taking it instead of the
name.
Line 39: var port = '4200';
Line 40: var shellUrl = 'http://' + hostAddress + ':' + port;
Line 41:
Line 42: return shellUrl;
--
To view, visit http://gerrit.ovirt.org/11166
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96c234e095e12b276ea6811274e17751de1f0b88
Gerrit-PatchSet: 1
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
