Daniel Erez has posted comments on this change.
Change subject: Introducing ShellBox UI plugin
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File shellbox-plugin/shellbox-files/start.html
Line 34: api.ready();
Line 35:
Line 36: // Get 'Shell Box' URL using specified host address
Line 37: var getShellBoxUrl = function(arguments) {
Line 38: var hostAddress = arguments[0].name;
It's already the address, the 'name' exposed by UI-Plugins infrastructure is
'host_name' field of VDS b.e. (as opposed to 'vds_name'...).
Line 39: var port = '4200';
Line 40: var shellUrl = 'http://' + hostAddress + ':' + port;
Line 41:
Line 42: return shellUrl;
--
To view, visit http://gerrit.ovirt.org/11166
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I96c234e095e12b276ea6811274e17751de1f0b88
Gerrit-PatchSet: 1
Gerrit-Project: samples-uiplugins
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
