Yair Zaslavsky has posted comments on this change. Change subject: core: Introduce AddGlusterFsStorageDomainCommand. ......................................................................
Patch Set 6: Shireesh - as you know our Command pattern implementation is based on reflection - If you have AddGlusterFsStorageDomain command at VdcActionType you must have a corresponding class, even if it adds no functionality on top of the super class. Maybe the question should be - why do we need this new command to begin with, but I guess Sharad and others felt its necessary to have a separate command (and not use the Add Posix FS storage domain ). -- To view, visit http://gerrit.ovirt.org/8837 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia62dd8732dee94a8478897845e1166ef2b1ef301 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
