Shireesh Anjal has posted comments on this change.

Change subject: core: Introduce AddGlusterFsStorageDomainCommand.
......................................................................


Patch Set 8: (1 inline comment)

....................................................
File 
backend/manager/dbscripts/upgrade/03_02_0350_add_addglusterstorage_domain_to_action_version_map.sql
Line 1: insert into action_version_map values(1012, '3.2','*');
I believe the first parameter must be the "value" of your command, as defined 
in VdcActionType. In this case, if you are trying to add the mapping for 
AddGlusterFsStorageDomainCommand, it should be 1413


--
To view, visit http://gerrit.ovirt.org/8837
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia62dd8732dee94a8478897845e1166ef2b1ef301
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepa...@linux.vnet.ibm.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to