Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-setup - make firewall checking more robust
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File packaging/fedora/setup/common_utils.py
Line 1290: if os.path.exists(basedefs.EXEC_SYSTEMCTL):
Line 1291: out, rc = execCmd(cmdList=cmd)
Line 1292: sysd = "LoadState=loaded" in out
Line 1293: else:
Line 1294: sysd = False
I would have put sysd = False at prefix... but not that important :)
Line 1295:
Line 1296: # Checks if systemV service available
Line 1297: sysv = os.path.exists("/etc/init.d/%s" % self.name)
Line 1298:
--
To view, visit http://gerrit.ovirt.org/11103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If10096e8f9e1141d2c0a45b600b0e82e849b59ba
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
