Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-setup - make firewall checking more robust
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 1284: # Checks if systemd service available
Line 1285: cmd = [
Line 1286: basedefs.EXEC_SYSTEMCTL,
Line 1287: "show",
Line 1288: self.name + ".service"
'%s.service' % self.name ?
Line 1289: ]
Line 1290: out, rc = execCmd(cmdList=cmd)
Line 1291: sysd = "LoadState=loaded" in out
Line 1292:
....................................................
File packaging/fedora/setup/engine-setup.py
Line 900: iptables = utils.Service("iptables")
Line 901: fwd = utils.Service("firewalld")
Line 902:
Line 903: # Add available services to list
Line 904: if os.path.exists(basedefs.EXEC_SYSTEMCTL) and fwd.available():
Why not do this at fwd available just before the execute? you should not expose
the fact of systemctl here.
Line 905: firewalls.append("Firewalld")
Line 906: if iptables.available():
Line 907: firewalls.append("IPTables")
Line 908:
--
To view, visit http://gerrit.ovirt.org/11103
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If10096e8f9e1141d2c0a45b600b0e82e849b59ba
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
