Gilad Chaplik has posted comments on this change.
Change subject: engine: quota caching fix
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
Line 373: requestIsApproved = true;
Line 374: }
Line 375: }
Line 376: // cache
Line 377: cacheNewValues(quotaVdsGroup, newMemory, newVcpu);
This line should be removed from the method (named: checkQuotaClusterLimits),
and sholud be called iff the ret val of the method (requestIsApproved) is true;
btw, this is the flow in storageLimits and a small cleanup is to return
true/false instead of setting requestIsApproved.
Line 378: return requestIsApproved;
Line 379: }
Line 380:
Line 381: private void cacheNewValues(QuotaVdsGroup quotaVdsGroup, long
newMemory, int newVcpu) {
--
To view, visit http://gerrit.ovirt.org/11083
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fad37c170e27d5cb78445c7c2fbcd9b3c7f9116
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
