Michael Pasternak has uploaded a new change for review. Change subject: sdk: add support for NULL params in constructor ......................................................................
sdk: add support for NULL params in constructor Change-Id: Ie3bfcf54f5f573850faa65a86391642cf784d8c2 Signed-off-by: Michael Pasternak <[email protected]> --- M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBuilder.java 2 files changed, 28 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine-sdk-java refs/changes/93/11093/1 diff --git a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java index 62d4147..89d6fe4 100644 --- a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java +++ b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/ConnectionsPoolBuilder.java @@ -135,8 +135,10 @@ * @param port * oVirt API port */ - public ConnectionsPoolBuilder port(int port) { - this.port = port; + public ConnectionsPoolBuilder port(Integer port) { + if (port != null) { + this.port = port.intValue(); + } return this; } @@ -144,8 +146,10 @@ * @param timeout * request timeout */ - public ConnectionsPoolBuilder timeout(int timeout) { - this.timeout = timeout; + public ConnectionsPoolBuilder timeout(Integer timeout) { + if (timeout != null) { + this.timeout = timeout.intValue(); + } return this; } @@ -172,8 +176,8 @@ cm.setMaxTotal(MAX_CONNECTIONS); cm.setDefaultMaxPerRoute(MAX_CONNECTIONS_PER_ROUTE); cm.setMaxPerRoute(new HttpRoute(new HttpHost(getHost(url), - getPort(url, port))), - MAX_CONNECTIONS_PER_HOST); + getPort(url, port))), + MAX_CONNECTIONS_PER_HOST); new IdleConnectionMonitorThread(cm, WAIT_IDLE_CHECK_TTL, WAIT_IDLE_CLOSE_TTL).start(); @@ -228,7 +232,7 @@ */ public ConnectionsPool build() { return new ConnectionsPool(createDefaultHttpClient(url, username, password, key_file, - cert_file, ca_file, port, timeout), - this.urlobj); + cert_file, ca_file, port, timeout), + this.urlobj); } } diff --git a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBuilder.java b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBuilder.java index fab72b7..e6f0f4c 100644 --- a/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBuilder.java +++ b/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/web/HttpProxyBuilder.java @@ -16,7 +16,6 @@ package org.ovirt.engine.sdk.web; - /** * Provides HttpProxy building services */ @@ -41,8 +40,10 @@ * @param persistentAuth * persistent authentication flag */ - public HttpProxyBuilder persistentAuth(boolean persistentAuth) { - this.persistentAuth = persistentAuth; + public HttpProxyBuilder persistentAuth(Boolean persistentAuth) { + if (persistentAuth != null) { + this.persistentAuth = persistentAuth.booleanValue(); + } return this; } @@ -50,8 +51,10 @@ * @param insecure * flag */ - public HttpProxyBuilder insecure(boolean insecure) { - this.insecure = insecure; + public HttpProxyBuilder insecure(Boolean insecure) { + if (insecure != null) { + this.insecure = insecure.booleanValue(); + } return this; } @@ -59,8 +62,10 @@ * @param filter * flag */ - public HttpProxyBuilder filter(boolean filter) { - this.filter = filter; + public HttpProxyBuilder filter(Boolean filter) { + if (filter != null) { + this.filter = filter.booleanValue(); + } return this; } @@ -68,8 +73,10 @@ * @param debug * flag */ - public HttpProxyBuilder debug(boolean debug) { - this.debug = debug; + public HttpProxyBuilder debug(Boolean debug) { + if (debug != null) { + this.debug = debug.booleanValue(); + } return this; } -- To view, visit http://gerrit.ovirt.org/11093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie3bfcf54f5f573850faa65a86391642cf784d8c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
