Omer Frenkel has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetEntityPermissionsQuery.java
Line 11: super(parameters);
Line 12: }
Line 13:
Line 14: @Override
Line 15: protected void executeQueryCommand() {
i think it would be better to use getUserId() so that the user will not be a
parameter, and users will not be able to query other users permissions.
Line 16: NGuid perm =
getDbFacade().getEntityPermissions(getParameters().getAdElementId(),
Line 17: getParameters().getActionGroup(),
Line 18: getParameters().getObjectId(),
Line 19: getParameters().getVdcObjectType());
--
To view, visit http://gerrit.ovirt.org/10770
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffce89a0c7bdd0cccb71943f398f0f907fbed002
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
