Roy Golan has posted comments on this change.
Change subject: engine: Display warning before overtaking spice console
......................................................................
Patch Set 4: (1 inline comment)
Omer and I spotted a bug in the impl. pls see inline
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ConsoleModel.java
Line 214: }
Line 215:
Line 216: //now we ask if the currently connected user has permission
to reconnect (async)
Line 217: GetRoleActionGroupsByUserIdParameters params =
Line 218: new
GetRoleActionGroupsByUserIdParameters(vm.getConsoleUserId());
the console user ID is *not* specific for VM.
in case where you have RECONNECT on one VM but not on other you get a false
answer.
The check should be VM specific.
Line 219:
Line 220: AsyncQuery query = new AsyncQuery();
Line 221: query.setModel(this);
Line 222: query.asyncCallback = new INewAsyncCallback() {
--
To view, visit http://gerrit.ovirt.org/10770
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffce89a0c7bdd0cccb71943f398f0f907fbed002
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
