Alex Lourie has posted comments on this change.
Change subject: packaging: Add yum installation indication for upgrade
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 600:
Line 601: def runFunc(funcList, dispString):
Line 602: print "%s..."%(dispString),
Line 603: sys.stdout.flush()
Line 604: if len(dispString)>=basedefs.SPACE_LEN:
Please keep it pep8 consistent as much as possible.
(Spaces around operators are considered a good practice):
len(dispString) >= basedefs.SPACE_LEN
splitlines = dispString.split('\n')
etc.
Line 605: splitlines=dispString.split('\n')
Line 606: dispString=splitlines[-1]
Line 607: spaceLen = basedefs.SPACE_LEN - len(dispString)
Line 608: try:
--
To view, visit http://gerrit.ovirt.org/9484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84cb11e35b24655e06c10136e0a545b278f1c663
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Haim Ateya <hat...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Simon Grinberg <sgrin...@redhat.com>
Gerrit-Reviewer: Yaniv Kaul <yk...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
