Alex Lourie has posted comments on this change.
Change subject: packaging: Add yum installation indication for upgrade
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 600:
Line 601: def runFunc(funcList, dispString):
Line 602: print "%s..."%(dispString),
Line 603: sys.stdout.flush()
Line 604: if len(dispString)>69:
why 69? We shouldn't use hard-coded values in the code.
Please replace with the length reference basedefs.SPACE_LEN
Line 605: splitlines=dispString.split('\n')
Line 606: dispString=splitlines[-1]
Line 607: spaceLen = basedefs.SPACE_LEN - len(dispString)
Line 608: try:
--
To view, visit http://gerrit.ovirt.org/9484
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84cb11e35b24655e06c10136e0a545b278f1c663
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Simon Grinberg <[email protected]>
Gerrit-Reviewer: Yaniv Kaul <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
