Alon Bar-Lev has posted comments on this change.
Change subject: packaging: updated setup to fail immediately if adding host
fails
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File packaging/fedora/setup/plugins/all_in_one_100.py
Line 76: logging.debug("plugin %s loaded", __name__)
Line 77:
Line 78:
Line 79: # Create a special Exception, so that it could be caught.
Line 80: class FailedHostException(Exception):
This exception should be at the retry module, no parameter is required.
Something as RetryFailException()
Here you can inherit FailedHostException from RetryFailException.
The retry will always not ignore the RetryFailException.
Code will be cleaner.
Line 81: pass
Line 82:
Line 83: def initConfig(controllerObject):
Line 84: global controller
--
To view, visit http://gerrit.ovirt.org/10578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I404af2b1702dbe5881cbd60d06a1b976b7a651a7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
