Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing dual PM handling code
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 334: secondaryResult = f.get();
Line 335: }
Line 336: }
Line 337:
Line 338: private FenceInvocationResult run(FenceExecutor executor,
FenceAgentOrder order) {
I know this is not a part of the original patch , but i would appreciate if you
give the argument a different name than the field, to make things more clear.
Line 339: FenceInvocationResult fenceInvocationResult = new
FenceInvocationResult();
Line 340: fenceInvocationResult.setOrder(order);
Line 341: fenceInvocationResult.setValue(executor.Fence(order));
Line 342: if (fenceInvocationResult.getValue().getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/10807
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0366b9615739f5e76b14beef5bc996645ee4f15b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
