Eli Mesika has uploaded a new change for review.

Change subject: core: fixing dual PM handling code
......................................................................

core: fixing dual PM handling code

This patch changes the executor assignment in the run method to
this.executor as it should be.
The local parameter masks the class variable and it is not used
correctly when waitForStatus is called without this change.

this patch is mandatory for RFE
https://bugzilla.redhat.com/show_bug.cgi?id=773108

Change-Id: I0366b9615739f5e76b14beef5bc996645ee4f15b
Signed-off-by: Eli Mesika <[email protected]>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/10807/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
index 7a5bbca..d0b01f5 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
@@ -340,7 +340,7 @@
         fenceInvocationResult.setOrder(order);
         fenceInvocationResult.setValue(executor.Fence(order));
         if (fenceInvocationResult.getValue().getSucceeded()) {
-            executor = new FenceExecutor(getVds(), FenceActionType.Status);
+            this.executor = new FenceExecutor(getVds(), 
FenceActionType.Status);
             
fenceInvocationResult.setSucceeded(waitForStatus(getVds().getvds_name(), 
getParameters().getAction(), order));
         }
         return fenceInvocationResult;


--
To view, visit http://gerrit.ovirt.org/10807
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0366b9615739f5e76b14beef5bc996645ee4f15b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to