Tomas Jelinek has posted comments on this change. Change subject: core: [RFE] Dislay Address Override ......................................................................
Patch Set 3: (1 inline comment) Actually I did run bll and dal tests and they all passed because the console_address is nullable. .................................................... File backend/manager/dbscripts/create_views.sql Line 645: vds_spm_id_map ON vds_static.vds_id = vds_spm_id_map.vds_id; Line 646: Line 647: Line 648: Line 649: CREATE OR REPLACE VIEW vds_with_tags I would say this view is not even used, at least according to git grep. Maybe we should delete it entirely. Line 650: as Line 651: SELECT vds_groups.vds_group_id, vds_groups.name AS vds_group_name, vds_groups.description AS vds_group_description, Line 652: vds_groups.selection_algorithm, vds_static.vds_id, vds_static.vds_name, vds_static.ip, vds_static.vds_unique_id, Line 653: vds_static.host_name, vds_static.port, vds_static.vds_strength, vds_static.server_SSL_enabled, vds_static.vds_type, -- To view, visit http://gerrit.ovirt.org/9022 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idacc0161a104c1de0969d86d98ddd5458c6787b8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
