Omer Frenkel has posted comments on this change.
Change subject: core: [RFE] Dislay Address Override
......................................................................
Patch Set 3: (3 inline comments)
did you run dal db tests? i think update is missing to the fixtures.xml file
....................................................
File backend/manager/dbscripts/create_views.sql
Line 645: vds_spm_id_map ON vds_static.vds_id = vds_spm_id_map.vds_id;
Line 646:
Line 647:
Line 648:
Line 649: CREATE OR REPLACE VIEW vds_with_tags
not needed in this view as well?
Line 650: as
Line 651: SELECT vds_groups.vds_group_id, vds_groups.name AS
vds_group_name, vds_groups.description AS vds_group_description,
Line 652: vds_groups.selection_algorithm,
vds_static.vds_id, vds_static.vds_name, vds_static.ip, vds_static.vds_unique_id,
Line 653: vds_static.host_name, vds_static.port,
vds_static.vds_strength, vds_static.server_SSL_enabled, vds_static.vds_type,
....................................................
File backend/manager/dbscripts/upgrade/03_01_1490_add_console_address.sql
Line 1: select fn_db_add_column('vds_static', 'console_address', 'VARCHAR(255)
default null');
this file name should be changed to 3.2 convention and to latest on rebase
....................................................
Commit Message
Line 3: AuthorDate: 2012-10-26 09:07:24 +0200
Line 4: Commit: Tomas Jelinek <tjeli...@redhat.com>
Line 5: CommitDate: 2012-11-05 10:46:26 +0100
Line 6:
Line 7: core: [RFE] Dislay Address Override
typo: Dislay->Display
Line 8:
Line 9: This patch introduces the possibility to override
Line 10: the display address of the host by an IP or FQDN
Line 11:
--
To view, visit http://gerrit.ovirt.org/9022
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idacc0161a104c1de0969d86d98ddd5458c6787b8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
