Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Default host for RunOnce dialog enabled
......................................................................


Patch Set 1: Verified

(1 inline comment)

verified with exception

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 721:         model.setHwAcceleration(true);
Line 722:         // disable Host tab
Line 723:         model.setIsHostTabValid(false);
Line 724:         model.getIsAutoAssign().setEntity(true);
Line 725: 
this line is problematic. in case the admin configured a host for the vm, run 
once will auto assign the vm?
Line 726:         fillIsoList(vm);
Line 727:         fillFloppyImages(vm);
Line 728: 
Line 729:         // passing Kernel parameters


--
To view, visit http://gerrit.ovirt.org/10654
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1906caf40c91e12a56523ddda794c72690947d4c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to