Libor Spevak has posted comments on this change.
Change subject: webadmin: Default host for RunOnce dialog enabled
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPayload.java
Line 43: }
Line 44: }
Line 45:
Line 46: public static boolean isPayload(Map<String, Object> specParams) {
Line 47: return specParams == null ? false :
specParams.containsKey(SpecParamsPayload);
I do not know the reason now, but this line caused NullPointerException.
Line 48: }
Line 49:
Line 50: public static boolean isPayloadSizeLegal(String payload) {
Line 51: return payload.length() <= Config.<Integer>
GetValue(ConfigValues.PayloadSize);
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
Line 719: model.getRunAsStateless().setEntity(vm.isStateless());
Line 720: model.getRunAndPause().setEntity(false);
Line 721: model.setHwAcceleration(true);
Line 722: // disable Host tab
Line 723: model.setIsHostTabValid(false);
I copied this terminology from Edit VM dialog.
Line 724: model.getIsAutoAssign().setEntity(true);
Line 725:
Line 726: fillIsoList(vm);
Line 727: fillFloppyImages(vm);
Line 721: model.setHwAcceleration(true);
Line 722: // disable Host tab
Line 723: model.setIsHostTabValid(false);
Line 724: model.getIsAutoAssign().setEntity(true);
Line 725:
Just because of uniform validation handling in UserPortal vs. Admin. This tab
is invisible, but some logic is activated on background.
Line 726: fillIsoList(vm);
Line 727: fillFloppyImages(vm);
Line 728:
Line 729: // passing Kernel parameters
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
Line 1554:
Line 1555: // disable host tab when no active host is available
Line 1556:
model.setIsHostTabValid(!model.getDefaultHost().getIsEmpty());
Line 1557: }
Line 1558:
Probably some code base unification could be useful in near future (e.g.
because of current code replication, etc.).
Line 1559: private void OnRunOnce()
Line 1560: {
Line 1561: VM vm = (VM) getSelectedItem();
Line 1562: if (vm == null)
--
To view, visit http://gerrit.ovirt.org/10654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1906caf40c91e12a56523ddda794c72690947d4c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
