Alissa Bonas has posted comments on this change.

Change subject: core: Locate data source in a loop
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java
Line 51:                     "check it. Will try again in a few seconds.");
Line 52: 
Line 53:                 // Wait a bit before trying again:
Line 54:                 Thread.sleep(DEFAULT_INTERVAL_VALUE);
Line 55:             }
Juan, adding to my and Yair's previous comments, I recommend to read about 
modules and their dependency management in JBoss 7.
Currently from what I saw, there is already a module for datasource postgres 
defined in the product.
so first make sure that the datasource is defined correctly
https://community.jboss.org/wiki/DataSourceConfigurationInAS7
And here are some links about the dependencies:
https://docs.jboss.org/author/display/AS7/Implicit+module+dependencies+for+deployments
https://docs.jboss.org/author/display/AS71/Class+Loading+in+AS7
https://community.jboss.org/thread/176211
Line 56: 
Line 57:             // Create the facade and return it:
Line 58:             dbFacade = new DbFacade();
Line 59:             dbFacade.setDbEngineDialect(loadDbEngineDialect());


--
To view, visit http://gerrit.ovirt.org/10189
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to