Alissa Bonas has posted comments on this change. Change subject: core: Locate data source in a loop ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java Line 51: "check it. Will try again in a few seconds."); Line 52: Line 53: // Wait a bit before trying again: Line 54: Thread.sleep(DEFAULT_INTERVAL_VALUE); Line 55: } I understand that it is not a small change that will require more changes, however I think making those changes presents a better (clearer, safer, etc) design that is worth the extra effort. IMHO - it's better invest in a better design then spend the same time afterwards on troubleshooting and resolving endless loops issues, potential stuck class loader and other problems that can arise which I mentioned in my previous comments. Line 56: Line 57: // Create the facade and return it: Line 58: dbFacade = new DbFacade(); Line 59: dbFacade.setDbEngineDialect(loadDbEngineDialect()); -- To view, visit http://gerrit.ovirt.org/10189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72c99c61d05e8a1619c7d1fb70af956d1050eb3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
