Alon Bar-Lev has posted comments on this change. Change subject: packaging: initial repo creation ......................................................................
Patch Set 11: (5 inline comments) split all inline files. I think the dummy should be persistent... Patches using find. Why do you keep pushing to here? you can use your own git until you finish. .................................................... File build.sh Line 1: #!/usr/bin/sh Line 2: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/i686/sanlock-2.6-5.fc18.i686.rpm space Line 3: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/x86_64/sanlock-lib-2.6-5.fc18.x86_64.rpm Line 4: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/x86_64/sanlock-python-2.6-5.fc18.x86_64.rpm Line 5: mv *.rpm ./oVirtLiveFiles/rpms/ Line 6: livecd-creator -d -v --config=kickstart/ovirt.ks --cache=/home --fslabel=ovirt-live-`cat VERSION` > iso.log 2>&1 || notify-send "Error" Line 1: #!/usr/bin/sh Line 2: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/i686/sanlock-2.6-5.fc18.i686.rpm Line 3: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/x86_64/sanlock-lib-2.6-5.fc18.x86_64.rpm space Line 4: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/x86_64/sanlock-python-2.6-5.fc18.x86_64.rpm Line 5: mv *.rpm ./oVirtLiveFiles/rpms/ Line 6: livecd-creator -d -v --config=kickstart/ovirt.ks --cache=/home --fslabel=ovirt-live-`cat VERSION` > iso.log 2>&1 || notify-send "Error" Line 1: #!/usr/bin/sh Line 2: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/i686/sanlock-2.6-5.fc18.i686.rpm Line 3: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/x86_64/sanlock-lib-2.6-5.fc18.x86_64.rpm Line 4: wget http://kojipkgs.fedoraproject.org//packages/sanlock/2.6/5.fc18/x86_64/sanlock-python-2.6-5.fc18.x86_64.rpm space Line 5: mv *.rpm ./oVirtLiveFiles/rpms/ Line 6: livecd-creator -d -v --config=kickstart/ovirt.ks --cache=/home --fslabel=ovirt-live-`cat VERSION` > iso.log 2>&1 || notify-send "Error" .................................................... File kickstart/ovirt-live-base.ks Line 1: # fedora-live-base.ks didn't we said we can get this file from external package? Line 2: # Line 3: # Defines the basics for all kickstarts in the fedora-live branch Line 4: # Does not include package selection (other then mandatory) Line 5: # Does not include localization packages or configuration .................................................... File oVirtLiveFiles/patches/0001-vdsm-bridge-handle-engine-at-loopback-all-in-one.patch Line 1: From 817103dfd95f00d894e54730b3789aa8a9cf1e63 Mon Sep 17 00:00:00 2001 Line 2: From: Alon Bar-Lev <alo...@redhat.com> Line 3: Date: Mon, 17 Dec 2012 17:11:04 +0200 Line 4: Subject: [PATCH] vdsm: bridge: handle engine at loopback (all-in-one) No need for this patch. Line 5: Line 6: When engine is at loopback we cannot create the bridge normally, as lo Line 7: cannot be added to a bridge. Line 8: -- To view, visit http://gerrit.ovirt.org/9733 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66cca8f5d5abaa710f054c59043ff6363b68256f Gerrit-PatchSet: 11 Gerrit-Project: ovirt-live Gerrit-Branch: master Gerrit-Owner: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches