Omer Frenkel has posted comments on this change.
Change subject: engine: Model the smartcard as a device
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 500: // add or remove the smartcard according to user
request
Line 501: if (getVm().isSmartcardEnabled() !=
getVmTemplate().isSmartcardEnabled())
Line 502: {
Line 503:
VmDeviceUtils.updateSmartcardDevice(getVm().getId(),
getVm().isSmartcardEnabled());
Line 504: }
right, if user change smartCard settings on update, it is taken care of inside
global devices update method in VmDeviceUtil which already called in update,
and the global method updated to calls this one (updateSmartCardDevice)
Line 505: setActionReturnValue(getVm().getId());
Line 506: setSucceeded(true);
Line 507: }
Line 508: } else {
--
To view, visit http://gerrit.ovirt.org/10302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92c88b64f3efdf6e5b6fa829ac4b0dac47868e4a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
