Roy Golan has posted comments on this change.
Change subject: engine: Model the smartcard as a device
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 500: // add or remove the smartcard according to user
request
Line 501: if (getVm().isSmartcardEnabled() !=
getVmTemplate().isSmartcardEnabled())
Line 502: {
Line 503:
VmDeviceUtils.updateSmartcardDevice(getVm().getId(),
getVm().isSmartcardEnabled());
Line 504: }
nice catch. updateVm is covered cause we don't care about the template, right?
Line 505: setActionReturnValue(getVm().getId());
Line 506: setSucceeded(true);
Line 507: }
Line 508: } else {
--
To view, visit http://gerrit.ovirt.org/10302
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92c88b64f3efdf6e5b6fa829ac4b0dac47868e4a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
