Ofer Schreiber has posted comments on this change. Change subject: packaging: Updated cleanup to ignore DB if no_drop_db supplied ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) Looks good small comment inside. .................................................... File packaging/fedora/setup/engine-cleanup.py Line 429: # Stop Engine Line 430: runFunc(stopEngine, MSG_INFO_STOP_ENGINE) Line 431: Line 432: # Backup DB, drop DB and clean .pgpass file (only if 'basedefs.DB_NAME' db exists) Line 433: # If no_drop_db option was supplied, will skip checking the DB what is no_drop_db? Line 434: if options.drop_db and db.exists(): Line 435: runFunc([db.backup, db.drop, cleanPgpass], MSG_INFO_REMOVE_DB) Line 436: Line 437: # Remove 00-ovirt.conf -- To view, visit http://gerrit.ovirt.org/10423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I699573fa24fc8b60f67437a4ec3005ced820ff22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
