Alex Lourie has uploaded a new change for review. Change subject: packaging: Updated cleanup to ignore DB if no_drop_db supplied ......................................................................
packaging: Updated cleanup to ignore DB if no_drop_db supplied This patch reverses the order for checking the DB presense and for the 'drop_db' option. First, we will check the option, and if it was not supplied, the DB will not be checked nor touched. Change-Id: I699573fa24fc8b60f67437a4ec3005ced820ff22 Bug-Url: https://bugzilla.redhat.com/888040 Signed-off-by: Alex Lourie <alou...@redhat.com> --- M packaging/fedora/setup/engine-cleanup.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/23/10423/1 diff --git a/packaging/fedora/setup/engine-cleanup.py b/packaging/fedora/setup/engine-cleanup.py index cfe24a0..51f2874 100755 --- a/packaging/fedora/setup/engine-cleanup.py +++ b/packaging/fedora/setup/engine-cleanup.py @@ -430,7 +430,8 @@ runFunc(stopEngine, MSG_INFO_STOP_ENGINE) # Backup DB, drop DB and clean .pgpass file (only if 'basedefs.DB_NAME' db exists) - if db.exists() and options.drop_db: + # If no_drop_db option was supplied, will skip checking the DB + if options.drop_db and db.exists(): runFunc([db.backup, db.drop, cleanPgpass], MSG_INFO_REMOVE_DB) # Remove 00-ovirt.conf -- To view, visit http://gerrit.ovirt.org/10423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I699573fa24fc8b60f67437a4ec3005ced820ff22 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alou...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
