Tal Nisan has posted comments on this change. Change subject: core: Rename ad_groups class to LdapGroup ......................................................................
Patch Set 5: I would prefer that you didn't submit this It' ll be redundant to comment on each file separately, basically I think we also need to change all the parameters name from adGroup to ldapGroup, all the method names (like getAdGroup()} and the AdGroupDao, while the other patches had residues of the old entity names like methodName(EventMapId event_map_id) which wasn't that much of a harm, in this case it's more important since the name is misleading since we are referring to a general Ldap while the param/method name is adGroup -- To view, visit http://gerrit.ovirt.org/9835 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic2429b55981a18cbb8fc9ceaf33d949195d66d8c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
