Michael Pasternak has posted comments on this change.

Change subject: restapi: Add fields for CPU Thread Handling (4/4)
......................................................................


Patch Set 8: (2 inline comments)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 911:       - mandatoryArguments: {}
Line 912:         optionalArguments: {cluster.name: 'xs:string', 
cluster.description: 'xs:string', cluster.cpu.id: 'xs:string', 
cluster.version.major: 'xs:int', cluster.version.minor: 'xs:int',
Line 913:         cluster.memory_policy.overcommit.percent: 'xs:double', 
cluster.memory_policy.transparent_hugepages.enabled: 'xs:boolean', 
cluster.scheduling_policy.policy: 'xs:string',
Line 914:         cluster.scheduling_policy.thresholds.low: 'xs:int', 
cluster.scheduling_policy.thresholds.high: 'xs:int', 
cluster.scheduling_policy.thresholds.duration: 'xs:int',
Line 915:         cluster.error_handling.on_error: 'xs:string', 
cluster.virt_service: 'xs:boolean', cluster.gluster_service: 'xs:boolean', 
threads_as_cores: 'xs:boolean'}
should be cluster.threads_as_cores: 'xs:boolean'
Line 916:     urlparams: {}
Line 917:     headers:
Line 918:       Content-Type: {value: application/xml|json, required: true}
Line 919:       Correlation-Id: {value: 'any string', required: false}


Line 924:       signatures:
Line 925:       - mandatoryArguments: {cluster.data_center.id|name: 
'xs:string', cluster.name: 'xs:string', cluster.version.major: 'xs:int', 
cluster.version.minor: 'xs:int', cluster.cpu.id: 'xs:string'}
Line 926:         optionalArguments: {cluster.description: 'xs:string', 
cluster.memory_policy.overcommit.percent: 'xs:double', 
cluster.memory_policy.transparent_hugepages.enabled: 'xs:boolean',
Line 927:         cluster.scheduling_policy.policy: 'xs:string', 
cluster.scheduling_policy.thresholds.low: 'xs:int', 
cluster.scheduling_policy.thresholds.high: 'xs:int',
Line 928:         cluster.scheduling_policy.thresholds.duration: 'xs:int', 
cluster.error_handling.on_error: 'xs:string', cluster.virt_service: 
'xs:boolean', cluster.gluster_service: 'xs:boolean', threads_as_cores: 
'xs:boolean'}
same
Line 929:     urlparams: {}
Line 930:     headers:
Line 931:       Content-Type: {value: application/xml|json, required: true}
Line 932:       Expect: {value: 201-created, required: false}


--
To view, visit http://gerrit.ovirt.org/10169
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8eebee7db2611276f58169aef196053542c7a5
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to