Greg Padgett has posted comments on this change.
Change subject: restapi: Add fields for CPU Thread Handling (3/4)
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 425: <xs:element name="name" type="xs:string" minOccurs="0"
maxOccurs="1"/>
Line 426: <xs:element name="speed" type="xs:decimal" minOccurs="0"
maxOccurs="1"/>
Line 427: <xs:element name="cpu_tune" type="CpuTune" minOccurs="0"
maxOccurs="1"/>
Line 428: <xs:element name="threads_enabled" type="xs:boolean"
minOccurs="0" maxOccurs="1"/>
Line 429: <xs:element name="vdsm_count_threads_as_cores"
type="xs:boolean" minOccurs="0" maxOccurs="1"/>
I kept the longer/distinct strings here (and line 1036) for now, but please see
my comment on patch set 2 about why it's for both hosts and clusters. Then we
can change either/both of them.
Line 430: </xs:sequence>
Line 431: <xs:attribute name="id" type="xs:string"/>
Line 432: </xs:complexType>
Line 433:
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/utils/FeaturesHelper.java
Line 175: feature.setDescription("Number of host sockets displayed.
'cores' now show num of cores per socket --> total cores in host is:
cores*sockets");
Line 176: feature.getHost().setCpu(new CPU());
Line 177: feature.getHost().getCpu().setTopology(new CpuTopology());
Line 178: feature.getHost().getCpu().getTopology().setSockets(4);
Line 179: if (VersionUtils.greaterOrEqual(version,
BackendCapabilitiesResource.VERSION_3_2)) {
I didn't see a precedent on adding version-specific "sub-features", let me know
if there's a better way to do it.
Line 180: feature.getHost().getCpu().setThreadsEnabled(true);
Line 181:
feature.getHost().getCpu().setVdsmCountThreadsAsCores(false);
Line 182: }
Line 183: features.getFeature().add(feature);
--
To view, visit http://gerrit.ovirt.org/10169
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8eebee7db2611276f58169aef196053542c7a5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
