Tal Nisan has posted comments on this change.
Change subject: core: Renamed event_notification_methods.java to
EventNotificationMethod.java
......................................................................
Patch Set 2: Looks good to me, approved
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java
Line 35:
addCanDoActionMessage(VdcBllMessages.EN_ALREADY_SUBSCRIBED);
Line 36: retValue = false;
Line 37: } else {
Line 38: // get notification method
Line 39: List<EventNotificationMethod> event_notification_methods =
(DbFacade.getInstance()
eventNotificationMethods
Line 40:
.getEventDao().getEventNotificationMethodsById(method_id));
Line 41: if (event_notification_methods.size() > 0) {
Line 42: // validate event
Line 43: List<event_map> event_map =
DbFacade.getInstance().getEventDao().getEventMapByName(event_name);
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveEventSubscriptionCommand.java
Line 18: @Override
Line 19: protected boolean canDoAction() {
Line 20: boolean retValue;
Line 21: // get notification method
Line 22: List<EventNotificationMethod> event_notification_methods =
(DbFacade.getInstance()
eventNotificationMethods
Line 23:
.getEventDao().getEventNotificationMethodsById(getParameters().getEventSubscriber().getmethod_id()));
Line 24: if (event_notification_methods.size() > 0) {
Line 25: // validate event
Line 26: List<event_map> event_map =
DbFacade.getInstance().getEventDao().getEventMapByName(
--
To view, visit http://gerrit.ovirt.org/10068
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I583ddb60b305af917db989f2dee0c22f0f7d5a24
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
