Alissa Bonas has posted comments on this change. Change subject: core: add line number to logged statements ......................................................................
Patch Set 1: BTW, it can also help us in production investigating things - searching more conveniently the logs and the code - it's just making the product more supportable. (but that's anyway not in this patch scope according to Oved) Why is it several reflection cycles? Could you please point me to an explanation/documentation regarding it? thanks... AFAIK, reflection's impact in such situations (considering the frequency, the deployment and the modern hardware) is nearly invisible. There were some issues around it, but it was in sun jdk pre version 5. And if there is a general concern around performance drawbacks caused by logs, then I suggest to stop printing the entire class name including its package -short class name is enough, switch printing things in debug instead of info , or set log to warn/error in production which is a common practice in enterprise software - it will lead to a better performance - (though the impact will also show only at a very large number of loggings per sec - and I am not sure the engine is printing that much) -- To view, visit http://gerrit.ovirt.org/10385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id53fd1e2879eea61d731ab2e94ccf49e612adcd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
