Moti Asayag has posted comments on this change. Change subject: core: add line number to logged statements ......................................................................
Patch Set 1: I would prefer that you didn't submit this The standalone.xml should be copied to the jboss deployment directory only when invoking the setup profile. This isn't commonly used (setup project might override personal settings on development which developers prefer to avoid, e.g. db-schema-name) Since there is no affect on how the product looks on production, this patch modifies the way development environment behaves. I agree with Roy and Mike not to apply this change by default and leave it to the hand of the developer which can modify this file at his destination. -- To view, visit http://gerrit.ovirt.org/10385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id53fd1e2879eea61d731ab2e94ccf49e612adcd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
