Liron Aravot has posted comments on this change.
Change subject: core: error when adding disks without specifying storage domain
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
Line 259: }
Line 260: }
Line 261:
Line 262: @Override
Line 263: public NGuid getStorageDomainId() {
it's called from audit log director also for lun disks, having it renamed will
cause that we won't get the storage domain from the audit log related methods.
anyway, i've collapsed a further patch to this change as well to solve all of
the related issues in this class (decided to send it in the same patch rather
then different one), so this comment isn't no longer relevant.
Line 264: Guid storageDomainId = getParameters().getStorageDomainId();
Line 265: if (Guid.Empty.equals(storageDomainId) &&
Line 266: getVm() != null &&
Line 267: getVm().getDiskMap() != null &&
--
To view, visit http://gerrit.ovirt.org/10289
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
