Eli Mesika has posted comments on this change. Change subject: Adding host bios fields to vdsStatic table ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql Line 131: select fn_db_add_config_value('NetworkLinkingSupported','true','3.2'); Line 132: select fn_db_add_config_value('DisconnectPoolOnReconstruct','0,2','general'); Line 133: select fn_db_add_config_value('HotPlugUnsupportedOsList','','general'); Line 134: select fn_db_add_config_value('InitStorageSparseSizeInGB','1','general'); Line 135: select fn_db_add_config_value('BiosInfoEnabled','false','3.0'); If this is just a 3.2 feature , it should be general and not have a per version value since there is no meaning for that , we haven't support for that for 3.0 and 3.1 Line 136: select fn_db_add_config_value('BiosInfoEnabled','false','3.1'); Line 137: select fn_db_add_config_value('BiosInfoEnabled','true','3.2'); Line 138: --Handling Install virtualization software on Add Host Line 139: -- To view, visit http://gerrit.ovirt.org/10114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id330288a13490475a61625eb0b6076153fec422f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches