Barak Azulay has posted comments on this change. Change subject: Adding host bios fields to vdsStatic table ......................................................................
Patch Set 1: I would prefer that you didn't submit this (3 inline comments) Please see inline comments And make sure the changes you submit comtain only changes relevant for the $subject , You shouldn't add white space changes in this patch .................................................... File backend/manager/dbscripts/create_views.sql Line 622: vds_static.host_name as host_name, vds_static.port as port, vds_static.vds_strength as vds_strength, vds_static.server_SSL_enabled as server_SSL_enabled, vds_static.vds_type as vds_type, Line 623: vds_static.pm_type as pm_type, vds_static.pm_user as pm_user, vds_static.pm_password as pm_password, vds_static.pm_port as pm_port, Line 624: vds_static.pm_options as pm_options, vds_static.pm_enabled as pm_enabled, vds_static.vds_spm_priority as vds_spm_priority, vds_dynamic.hooks as hooks,vds_dynamic.status as status, Line 625: vds_dynamic.cpu_cores as cpu_cores, Line 626: vds_dynamic.cpu_model as cpu_model, vds_dynamic.cpu_speed_mh as cpu_speed_mh, vds_dynamic.if_total_speed as if_total_speed, vds_dynamic.kvm_enabled as kvm_enabled, vds_dynamic.physical_mem_mb as physical_mem_mb, please remove white spaces Line 627: vds_dynamic.pending_vcpus_count as pending_vcpus_count, vds_dynamic.pending_vmem_size as pending_vmem_size,vds_dynamic.mem_commited as mem_commited, vds_dynamic.vm_active as vm_active, vds_dynamic.vm_count as vm_count, Line 628: vds_dynamic.vm_migrating as vm_migrating, vds_dynamic.vms_cores_count as vms_cores_count, vds_dynamic.cpu_over_commit_time_stamp as cpu_over_commit_time_stamp, Line 629: vds_dynamic.net_config_dirty as net_config_dirty, vds_groups.high_utilization as high_utilization, vds_groups.low_utilization as low_utilization, Line 630: vds_groups.max_vds_memory_over_commit as max_vds_memory_over_commit, vds_groups.cpu_over_commit_duration_minutes as cpu_over_commit_duration_minutes, Line 638: CASE WHEN storage_pool.spm_vds_id = vds_static.vds_id THEN CASE WHEN storage_pool.status = 5 THEN 1 ELSE 2 END ELSE 0 END as spm_status, vds_dynamic.supported_cluster_levels as supported_cluster_levels, vds_dynamic.supported_engines as supported_engines, vds_groups.compatibility_version as vds_group_compatibility_version, Line 639: vds_dynamic.host_os as host_os, vds_dynamic.kvm_version as kvm_version, vds_dynamic.libvirt_version as libvirt_version, vds_dynamic.spice_version as spice_version, vds_dynamic.kernel_version as kernel_version, vds_dynamic.iscsi_initiator_name as iscsi_initiator_name, Line 640: vds_dynamic.transparent_hugepages_state as transparent_hugepages_state, vds_dynamic.anonymous_hugepages as anonymous_hugepages, vds_dynamic.non_operational_reason as non_operational_reason, Line 641: vds_static.recoverable as recoverable, vds_static.sshKeyFingerprint as sshKeyFingerprint, vds_static.host_manufacturer as host_manufacturer, vds_static.host_product_name as host_product_name, vds_static.host_version as host_version, Line 642: vds_static.host_serial_number as host_serial_number, vds_static.host_uuid as host_uuid, vds_static.host_family as host_family I would prefer that all the paras brought from bios should include _bios_ in the name E.G host_version should be host_bios_version Line 643: FROM vds_groups INNER JOIN Line 644: vds_static ON vds_groups.vds_group_id = vds_static.vds_group_id INNER JOIN Line 645: vds_dynamic ON vds_static.vds_id = vds_dynamic.vds_id INNER JOIN Line 646: vds_statistics ON vds_static.vds_id = vds_statistics.vds_id LEFT OUTER JOIN .................................................... File backend/manager/dbscripts/vds_sp.sql Line 384: v_host_product_name VARCHAR(40), Line 385: v_host_version VARCHAR(40), Line 386: v_host_serial_number VARCHAR(40), Line 387: v_host_uuid VARCHAR(40), Line 388: v_host_family VARCHAR(40)) Why are all the above only VARCHAR (40), Does the bios specs contain any length limitation. Keep in mind we'll have a lot of bioses that may return more than 40. I would go with a safer number (or check whether bios has limitation) Line 389: RETURNS VOID Line 390: Line 391: --The [vds_static] table doesn't have a timestamp column. Optimistic concurrency logic cannot be generated Line 392: AS $procedure$ -- To view, visit http://gerrit.ovirt.org/10114 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id330288a13490475a61625eb0b6076153fec422f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
