Einav Cohen has posted comments on this change. Change subject: engine: VM Linux Boot options aren't parsing properly ......................................................................
Patch Set 3: AFAIR, today we are not manipulating any user-input, so current approach of not trimming the whitespaces and raising a validation error instead seems OK to me. We can look into trimming whitespaces across the entire application (not only to the linux boot parameters) separately. -- To view, visit http://gerrit.ovirt.org/9550 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Libor Spevak <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
