Allon Mureinik has posted comments on this change. Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm ......................................................................
Patch Set 1: No score @Arik - I understand the need, but am not a fan of the implementation. Here's another idea - you can extract that logic to a method (validateMigrationStatus()) or something like that. In the MigrateVmCommand, you have the logic that refers to force, and in the InternalMigrateCommand you have the new logic you present here. @Roy - I'll rephrase. Today, you have MigrateVmParameters which has a force flag. Theoretically (javawise) it could be set to true, but in practice it never is, and if it would be, it would not work. I claim that if this is the case (and admittedly, I may be missing something - correct me if I'm wrong), this is misleading. The InternalMigrateParameters sounds like a great idea. -- To view, visit http://gerrit.ovirt.org/10107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida10d53ccd5321d3ccc510bd2111fa013dcdcdbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
