Allon Mureinik has posted comments on this change. Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm ......................................................................
Patch Set 1: I would prefer that you didn't submit this This code is redundent. super.canMigrateVM already checks the MigrationStatus, unless you have forceMigrate=true. But the only place that creates an InternalMigrateCommand sends forceMigrate=false. I'd make InternalMigrateCommand force that forceMigrate=false (perhaps by extending the parameter class?), and then you don't need all of the double checking here. -- To view, visit http://gerrit.ovirt.org/10107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida10d53ccd5321d3ccc510bd2111fa013dcdcdbe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
