Mike Kolesnik has posted comments on this change. Change subject: core: create UpdateVmInterfaceVDSCommand ......................................................................
Patch Set 11: (1 inline comment) .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java Line 207: public static final String Custom = "custom"; Line 208: public static final String Type = "type"; Line 209: public static final String DeviceId = "deviceId"; Line 210: public static final String Device = "device"; Line 211: public static final String DeviceType = "deviceType"; OK but there is also "device" field and there is also "type" field so another field "deviceType" adds confusion as to which of these fields it relates to, and rather looks like some combo of both Line 212: public static final String Devices = "devices"; Line 213: public static final String Index = "index"; Line 214: public static final String Iface = "iface"; Line 215: public static final String PoolId = "poolID"; -- To view, visit http://gerrit.ovirt.org/9669 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc54fedde0fdf6ea9694fc19977bf1178e73efdf Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
