Alona Kaplan has posted comments on this change.
Change subject: core: create UpdateVmInterfaceVDSCommand
......................................................................
Patch Set 11: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpdateVmInterfaceVDSParameters.java
Line 4: import org.ovirt.engine.core.common.businessentities.VmDevice;
Line 5: import org.ovirt.engine.core.common.businessentities.VmNetworkInterface;
Line 6: import org.ovirt.engine.core.compat.Guid;
Line 7:
Line 8: public class UpdateVmInterfaceVDSParameters extends
VmUpdateDeviceVDSParameters {
I will rename this class to VmNicDeviceVDSParameters, and the parent class to
VmDeviceVDSParameters.
And remove HotPlugUnplugNicVDSParameters.
Line 9:
Line 10: private final VmNetworkInterface nic;
Line 11:
Line 12: public UpdateVmInterfaceVDSParameters(Guid vdsId, VM vm,
VmNetworkInterface nic, VmDevice vmDevice) {
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmUpdateDeviceVDSParameters.java
Line 3: import org.ovirt.engine.core.common.businessentities.VM;
Line 4: import org.ovirt.engine.core.common.businessentities.VmDevice;
Line 5: import org.ovirt.engine.core.compat.Guid;
Line 6:
Line 7: public class VmUpdateDeviceVDSParameters extends
VdsIdVDSCommandParametersBase {
This class can be used in the future for updating other devices- like disks.
We've called the vdsm command "vmUpdateDevice" in order to reuse it for other
devices.
Line 8:
Line 9: private final VM vm;
Line 10: private final VmDevice vmDevice;
Line 11:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmUpdateDeviceVDSCommand.java
Line 2:
Line 3: import
org.ovirt.engine.core.common.vdscommands.VmUpdateDeviceVDSParameters;
Line 4: import org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcStruct;
Line 5:
Line 6: public abstract class VmUpdateDeviceVDSCommand<P extends
VmUpdateDeviceVDSParameters> extends VdsBrokerCommand<P> {
See my answer to the comment on VmUpdateDeviceVDSParameters.java.
Line 7:
Line 8: protected XmlRpcStruct deviceStruct = new XmlRpcStruct();
Line 9:
Line 10: public VmUpdateDeviceVDSCommand(P parameters) {
--
To view, visit http://gerrit.ovirt.org/9669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc54fedde0fdf6ea9694fc19977bf1178e73efdf
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
