Arik Hadas has posted comments on this change.
Change subject: userportal: allow connection to guest with non resp agent
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
Line 70:
errorPopupManager.show(ErrorMessageFormatter.formatErrorMessages(errors));
Line 71: }
Line 72:
Line 73: private boolean shouldRaiseErrorDialog(VdcActionType actionType,
VdcFault fault) {
Line 74: return !(actionType == VdcActionType.VmLogon &&
fault.getError() == VdcBllErrors.nonresp);
I see but an error must be returned, so that the warning dialog will be shown
to the user in such case (the frontend must know that the logon operation
failed and why..), and also from the backend perspective it makes sense to
return such error (also for the REST api)
I thought about adding a flag to the return value that indicates whether to
show an error dialog and then the FrontendEventsHandlerImpl will stay generic,
but this is more a frontend responsibility to determine whether to show such
dialog or not I think
do you have a suggestion how to change it?
Line 75: }
Line 76:
Line 77: @Override
Line 78: public void runQueryFailed(List<VdcQueryReturnValue> returnValue) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceToGuestWithNonRespAgentModel.java
Line 2:
Line 3: import org.ovirt.engine.ui.uicommonweb.models.ConfirmationModel;
Line 4:
Line 5: public class SpiceToGuestWithNonRespAgentModel extends
ConfirmationModel {
Line 6:
It is used to signal which provider to return in the getModelPopup method of
UserPortalListProvider and UserPortalBasicListProvider.
There is no command for open spice console (there's a general command to open
console that can be one of spice console, vnc console or rdp console) - so I
can't determine which popup to show based on the last executed command, so I'm
querying in which model the popup was requested and according to that I choose
the popup provider (in a similar way the VNC popup is chosen).
--
To view, visit http://gerrit.ovirt.org/10030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaf009f5ff99946dbb421459ccdec9c536aea58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
