Daniel Erez has posted comments on this change.
Change subject: userportal: allow connection to guest with non resp agent
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendEventsHandlerImpl.java
Line 70:
errorPopupManager.show(ErrorMessageFormatter.formatErrorMessages(errors));
Line 71: }
Line 72:
Line 73: private boolean shouldRaiseErrorDialog(VdcActionType actionType,
VdcFault fault) {
Line 74: return !(actionType == VdcActionType.VmLogon &&
fault.getError() == VdcBllErrors.nonresp);
It is preferable to not include any specific ActionType here (since
FrontendEventsHandlerImpl is a generic class).
Any chance to modify VmLogon command instead (i.e. simply not return an error
to prevent the error dialog)?
Line 75: }
Line 76:
Line 77: @Override
Line 78: public void runQueryFailed(List<VdcQueryReturnValue> returnValue) {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceToGuestWithNonRespAgentModel.java
Line 2:
Line 3: import org.ovirt.engine.ui.uicommonweb.models.ConfirmationModel;
Line 4:
Line 5: public class SpiceToGuestWithNonRespAgentModel extends
ConfirmationModel {
Line 6:
Why this class is needed?
--
To view, visit http://gerrit.ovirt.org/10030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4eaf009f5ff99946dbb421459ccdec9c536aea58
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
