Roy Golan has posted comments on this change.
Change subject: core: renamed AdUser to LdapUser.
......................................................................
Patch Set 2: (5 inline comments)
pls make sure you also verify with search from the UI or REST just to be safe
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
Line 81: * detect differences between current DB users and the directory
server users/groups and persist them
Line 82: *
Line 83: * @param dbUser
Line 84: * DB user
Line 85: * @param adUser
rename adUser in the comment
Line 86: * LDAP user
Line 87: * @param updatedUsers
Line 88: * list of changed users.
Line 89: */
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
Line 123: }
Line 124:
Line 125: protected abstract UserAuthenticationResult authenticateUser();
Line 126:
Line 127: protected LdapUser _ldapUser;
pls remove this annoying underscore as well!
Line 128:
Line 129: @Override
Line 130: protected void executeCommand() {
Line 131: // add user session
....................................................
File
backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/users/VdcUserTest.java
Line 10:
Line 11: /** A test case for the {@link VdcUser} class. */
Line 12: public class VdcUserTest {
Line 13:
Line 14: /** The AdUser to create VdcUsers from */
rename AdUser in the comment
Line 15: private LdapUser adUser;
Line 16:
Line 17: @Before
Line 18: public void setUp() {
Line 18: public void setUp() {
Line 19: adUser = new LdapUser("UserName", "password", Guid.NewGuid(),
"DomainController");
Line 20: }
Line 21:
Line 22: /** Tests {@link VdcUser#VdcUser(AdUser)) */
rename AdUser in the comment
Line 23: @Test
Line 24: public void testAdUserConstrcutor() {
Line 25: VdcUser user = new VdcUser(adUser);
Line 26: assertFalse("By default, a user should not be an admin",
user.isAdmin());
Line 27: user.setAdmin(true);
Line 28: assertTrue("after being set as such, the user should be an
admin", user.isAdmin());
Line 29: }
Line 30:
Line 31: /** Tests {@link VdcUser#VdcUser(AdUser, boolean)) */
rename AdUser in the comment
Line 32: @Test
Line 33: public void testAdUserAndFalseBooleanConstrcutor() {
Line 34: VdcUser user = new VdcUser(adUser, false);
Line 35: assertFalse("If not set, a user should not be an admin",
user.isAdmin());
--
To view, visit http://gerrit.ovirt.org/10014
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I072b276401c7026bae9ee8bdcd6848f431a001a0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
