Maor Lipchuk has posted comments on this change.
Change subject: engine: cpu host feature
......................................................................
Patch Set 11: (4 inline comments)
What about fixtures, also (as Omer also mentioned in patchset 9), isn't this
field should also be in template?
....................................................
File backend/manager/dbscripts/vms_sp.sql
Line 307: v_userdefined_properties VARCHAR(4000),
Line 308: v_min_allocated_mem INTEGER,
Line 309: v_quota_id UUID,
Line 310: v_cpu_pinning VARCHAR(4000),
Line 311: v_host_cpu_flags boolean)
please switch boolean type to upper case, to keep an unified standard
Line 312: RETURNS VOID
Line 313: AS $procedure$
Line 314: BEGIN
Line 315: INSERT INTO vm_static(description, mem_size_mb, os, vds_group_id,
vm_guid, VM_NAME,
vmt_guid,domain,creation_date,num_of_monitors,allow_console_reconnect,is_initialized,is_auto_suspend,num_of_sockets,cpu_per_socket,usb_policy,
time_zone,auto_startup,is_stateless,dedicated_vm_for_vds, fail_back,
default_boot_sequence, vm_type, nice_level, default_display_type,
priority,iso_path,origin,initrd_url,kernel_url,kernel_params,migration_support,predefined_properties,userdefined_properties,min_allocated_mem,
entity_type, quota_id, cpu_pinning,
is_smartcard_enabled,is_delete_protected,host_cpu_flags)
Line 359: v_userdefined_properties VARCHAR(4000),
Line 360: v_min_allocated_mem INTEGER,
Line 361: v_quota_id UUID,
Line 362: v_cpu_pinning VARCHAR(4000),
Line 363: v_host_cpu_flags boolean)
please switch boolean type to upper case, to keep an unified standard
Line 364: RETURNS VOID
Line 365:
Line 366: --The [vm_static] table doesn't have a timestamp column.
Optimistic concurrency logic cannot be generated
Line 367: AS $procedure$
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
Line 68: @Column(name = "cpu_pinning")
Line 69: private String cpuPinning;
Line 70:
Line 71: @Column(name = "host_cpu_flags", nullable = false)
Line 72: private boolean useHostCpuFlags = false;
Isn't this field should also be in equals() or hashCode()
Line 73:
Line 74: public VmStatic() {
Line 75: setnum_of_monitors(1);
Line 76: is_initialized = false;
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilderBase.java
Line 76: if(vm.isUseHostCpuFlags()) {
Line 77: createInfo.add(VdsProperties.cpuType,
Line 78: "hostPassthrough");
Line 79: } else {
Line 80: if (vm.getVdsGroupCpuFlagsData() != null) {
please use "else if", in one statement, instead "else { if..."
Line 81: createInfo.add(VdsProperties.cpuType,
Line 82: vm.getVdsGroupCpuFlagsData());
Line 83: }
Line 84: }
--
To view, visit http://gerrit.ovirt.org/9753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I84bfce49a3b74595e68dfc1e7494dd20008ac9bc
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
